meonkeys commented on code in PR #4529: URL: https://github.com/apache/fineract/pull/4529#discussion_r2024897556
########## README.md: ########## @@ -144,15 +144,54 @@ We recommend using the JAR instead of the WAR file deployment, because it's much Note that with the 1.4 release the tenants database pool configuration changed from Tomcat DBCP in XML to an embedded Hikari, configured by environment variables, see above. -INSTRUCTIONS: How to execute Integration Tests +INSTRUCTIONS: How to run tests ============ -> Note that if this is the first time to access MySQL DB, then you may need to reset your password. -Run the following commands: Review Comment: Not to split hairs: I'm renaming the section, not removing it. I do think we should rename this section because it is now about *all* tests: "Unit" and "Integration" (see lines 150 and 162). We might also want to call out "e2e" or "acceptance" or "smoke" or "bdd/cucumber" tests separately, but my idea for now is just to differentiate "quick/independent/Unit" and "slow/external dependencies/Integration". I care less about abusing those terms than making it easy and possible for new devs to actually run tests reliably. I think we also need to clean up, simplify, and otherwise improve the gradle tasks because they are just bananas right now. 🍌 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
