adamsaghy commented on code in PR #4432:
URL: https://github.com/apache/fineract/pull/4432#discussion_r2003100356
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoanTransactionsApiResource.java:
##########
@@ -637,4 +729,19 @@ private Long getResolvedLoanId(final Long loanId, final
ExternalId loanExternalI
}
return resolvedLoanId;
}
+
+ private Long getResolvedLoanIdWithExistsCheck(final Long loanId, final
ExternalId loanExternalId) {
+ if (loanId != null) {
+ loanReadPlatformService.retrieveOne(loanId);
Review Comment:
Would you mind to rework this? We dont want to fetch loan and map a loan
data for no reason... :/
if you want to check whether it is existing, do with exists query or do it
at a later stage once you fetch the loan...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
