somasorosdpc commented on code in PR #4482:
URL: https://github.com/apache/fineract/pull/4482#discussion_r2028158179
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepaymentScheduleInstallment.java:
##########
@@ -54,73 +57,79 @@ public class LoanRepaymentScheduleInstallment extends
AbstractAuditableWithUTCDa
@Column(name = "installment", nullable = false)
private Integer installmentNumber;
- @Column(name = "fromdate", nullable = true)
+ @Column(name = "fromdate")
private LocalDate fromDate;
@Column(name = "duedate", nullable = false)
private LocalDate dueDate;
- @Column(name = "principal_amount", scale = 6, precision = 19, nullable =
true)
+ @Column(name = "principal_amount", scale = 6, precision = 19)
private BigDecimal principal;
- @Column(name = "principal_completed_derived", scale = 6, precision = 19,
nullable = true)
+ @Column(name = "principal_completed_derived", scale = 6, precision = 19)
private BigDecimal principalCompleted;
- @Column(name = "principal_writtenoff_derived", scale = 6, precision = 19,
nullable = true)
+ @Column(name = "principal_writtenoff_derived", scale = 6, precision = 19)
private BigDecimal principalWrittenOff;
- @Column(name = "interest_amount", scale = 6, precision = 19, nullable =
true)
+ @Column(name = "interest_amount", scale = 6, precision = 19)
private BigDecimal interestCharged;
- @Column(name = "interest_completed_derived", scale = 6, precision = 19,
nullable = true)
+ @Column(name = "interest_completed_derived", scale = 6, precision = 19)
private BigDecimal interestPaid;
- @Column(name = "interest_waived_derived", scale = 6, precision = 19,
nullable = true)
+ @Column(name = "interest_waived_derived", scale = 6, precision = 19)
private BigDecimal interestWaived;
- @Column(name = "interest_writtenoff_derived", scale = 6, precision = 19,
nullable = true)
+ @Column(name = "interest_writtenoff_derived", scale = 6, precision = 19)
private BigDecimal interestWrittenOff;
- @Column(name = "accrual_interest_derived", scale = 6, precision = 19,
nullable = true)
+ @Setter
+ @Column(name = "accrual_interest_derived", scale = 6, precision = 19)
private BigDecimal interestAccrued;
- @Column(name = "reschedule_interest_portion", scale = 6, precision = 19,
nullable = true)
+ @Setter
Review Comment:
Unnecessarry @Setter
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepaymentScheduleInstallment.java:
##########
@@ -54,73 +57,79 @@ public class LoanRepaymentScheduleInstallment extends
AbstractAuditableWithUTCDa
@Column(name = "installment", nullable = false)
private Integer installmentNumber;
- @Column(name = "fromdate", nullable = true)
+ @Column(name = "fromdate")
private LocalDate fromDate;
@Column(name = "duedate", nullable = false)
private LocalDate dueDate;
- @Column(name = "principal_amount", scale = 6, precision = 19, nullable =
true)
+ @Column(name = "principal_amount", scale = 6, precision = 19)
private BigDecimal principal;
- @Column(name = "principal_completed_derived", scale = 6, precision = 19,
nullable = true)
+ @Column(name = "principal_completed_derived", scale = 6, precision = 19)
private BigDecimal principalCompleted;
- @Column(name = "principal_writtenoff_derived", scale = 6, precision = 19,
nullable = true)
+ @Column(name = "principal_writtenoff_derived", scale = 6, precision = 19)
private BigDecimal principalWrittenOff;
- @Column(name = "interest_amount", scale = 6, precision = 19, nullable =
true)
+ @Column(name = "interest_amount", scale = 6, precision = 19)
private BigDecimal interestCharged;
- @Column(name = "interest_completed_derived", scale = 6, precision = 19,
nullable = true)
+ @Column(name = "interest_completed_derived", scale = 6, precision = 19)
private BigDecimal interestPaid;
- @Column(name = "interest_waived_derived", scale = 6, precision = 19,
nullable = true)
+ @Column(name = "interest_waived_derived", scale = 6, precision = 19)
private BigDecimal interestWaived;
- @Column(name = "interest_writtenoff_derived", scale = 6, precision = 19,
nullable = true)
+ @Column(name = "interest_writtenoff_derived", scale = 6, precision = 19)
private BigDecimal interestWrittenOff;
- @Column(name = "accrual_interest_derived", scale = 6, precision = 19,
nullable = true)
+ @Setter
+ @Column(name = "accrual_interest_derived", scale = 6, precision = 19)
private BigDecimal interestAccrued;
- @Column(name = "reschedule_interest_portion", scale = 6, precision = 19,
nullable = true)
+ @Setter
+ @Column(name = "reschedule_interest_portion", scale = 6, precision = 19)
private BigDecimal rescheduleInterestPortion;
- @Column(name = "fee_charges_amount", scale = 6, precision = 19, nullable =
true)
+ @Column(name = "fee_charges_amount", scale = 6, precision = 19)
private BigDecimal feeChargesCharged;
- @Column(name = "fee_charges_completed_derived", scale = 6, precision = 19,
nullable = true)
+ @Column(name = "fee_charges_completed_derived", scale = 6, precision = 19)
private BigDecimal feeChargesPaid;
- @Column(name = "fee_charges_writtenoff_derived", scale = 6, precision =
19, nullable = true)
+ @Column(name = "fee_charges_writtenoff_derived", scale = 6, precision = 19)
private BigDecimal feeChargesWrittenOff;
- @Column(name = "fee_charges_waived_derived", scale = 6, precision = 19,
nullable = true)
+ @Setter
+ @Column(name = "fee_charges_waived_derived", scale = 6, precision = 19)
private BigDecimal feeChargesWaived;
- @Column(name = "accrual_fee_charges_derived", scale = 6, precision = 19,
nullable = true)
+ @Setter
Review Comment:
As you added @Getter and @Setter to class, these field level annotations are
not needed anymore, could you please clean them up?
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanInstallmentCharge.java:
##########
@@ -24,30 +24,36 @@
import jakarta.persistence.ManyToOne;
import jakarta.persistence.Table;
import java.math.BigDecimal;
+import lombok.Getter;
+import lombok.Setter;
import
org.apache.fineract.infrastructure.core.domain.AbstractPersistableCustom;
import org.apache.fineract.infrastructure.core.service.MathUtil;
import org.apache.fineract.organisation.monetary.domain.MonetaryCurrency;
import org.apache.fineract.organisation.monetary.domain.Money;
import
org.apache.fineract.portfolio.loanaccount.data.LoanInstallmentChargeData;
@Entity
+@Getter
@Table(name = "m_loan_installment_charge")
public class LoanInstallmentCharge extends AbstractPersistableCustom<Long>
implements Comparable<LoanInstallmentCharge> {
@ManyToOne(optional = false)
@JoinColumn(name = "loan_charge_id", referencedColumnName = "id", nullable
= false)
private LoanCharge loancharge;
+ @Setter
@ManyToOne
@JoinColumn(name = "loan_schedule_id", nullable = false)
private LoanRepaymentScheduleInstallment installment;
+ @Getter
Review Comment:
Unnecessary @Getter
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepaymentScheduleInstallment.java:
##########
@@ -54,73 +57,79 @@ public class LoanRepaymentScheduleInstallment extends
AbstractAuditableWithUTCDa
@Column(name = "installment", nullable = false)
private Integer installmentNumber;
- @Column(name = "fromdate", nullable = true)
+ @Column(name = "fromdate")
private LocalDate fromDate;
@Column(name = "duedate", nullable = false)
private LocalDate dueDate;
- @Column(name = "principal_amount", scale = 6, precision = 19, nullable =
true)
+ @Column(name = "principal_amount", scale = 6, precision = 19)
private BigDecimal principal;
- @Column(name = "principal_completed_derived", scale = 6, precision = 19,
nullable = true)
+ @Column(name = "principal_completed_derived", scale = 6, precision = 19)
private BigDecimal principalCompleted;
- @Column(name = "principal_writtenoff_derived", scale = 6, precision = 19,
nullable = true)
+ @Column(name = "principal_writtenoff_derived", scale = 6, precision = 19)
private BigDecimal principalWrittenOff;
- @Column(name = "interest_amount", scale = 6, precision = 19, nullable =
true)
+ @Column(name = "interest_amount", scale = 6, precision = 19)
private BigDecimal interestCharged;
- @Column(name = "interest_completed_derived", scale = 6, precision = 19,
nullable = true)
+ @Column(name = "interest_completed_derived", scale = 6, precision = 19)
private BigDecimal interestPaid;
- @Column(name = "interest_waived_derived", scale = 6, precision = 19,
nullable = true)
+ @Column(name = "interest_waived_derived", scale = 6, precision = 19)
private BigDecimal interestWaived;
- @Column(name = "interest_writtenoff_derived", scale = 6, precision = 19,
nullable = true)
+ @Column(name = "interest_writtenoff_derived", scale = 6, precision = 19)
private BigDecimal interestWrittenOff;
- @Column(name = "accrual_interest_derived", scale = 6, precision = 19,
nullable = true)
+ @Setter
+ @Column(name = "accrual_interest_derived", scale = 6, precision = 19)
private BigDecimal interestAccrued;
- @Column(name = "reschedule_interest_portion", scale = 6, precision = 19,
nullable = true)
+ @Setter
+ @Column(name = "reschedule_interest_portion", scale = 6, precision = 19)
private BigDecimal rescheduleInterestPortion;
- @Column(name = "fee_charges_amount", scale = 6, precision = 19, nullable =
true)
+ @Column(name = "fee_charges_amount", scale = 6, precision = 19)
private BigDecimal feeChargesCharged;
- @Column(name = "fee_charges_completed_derived", scale = 6, precision = 19,
nullable = true)
+ @Column(name = "fee_charges_completed_derived", scale = 6, precision = 19)
private BigDecimal feeChargesPaid;
- @Column(name = "fee_charges_writtenoff_derived", scale = 6, precision =
19, nullable = true)
+ @Column(name = "fee_charges_writtenoff_derived", scale = 6, precision = 19)
private BigDecimal feeChargesWrittenOff;
- @Column(name = "fee_charges_waived_derived", scale = 6, precision = 19,
nullable = true)
+ @Setter
+ @Column(name = "fee_charges_waived_derived", scale = 6, precision = 19)
private BigDecimal feeChargesWaived;
- @Column(name = "accrual_fee_charges_derived", scale = 6, precision = 19,
nullable = true)
+ @Setter
Review Comment:
Unnecessary @Setter
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepaymentScheduleInstallment.java:
##########
@@ -54,73 +57,79 @@ public class LoanRepaymentScheduleInstallment extends
AbstractAuditableWithUTCDa
@Column(name = "installment", nullable = false)
private Integer installmentNumber;
- @Column(name = "fromdate", nullable = true)
+ @Column(name = "fromdate")
private LocalDate fromDate;
@Column(name = "duedate", nullable = false)
private LocalDate dueDate;
- @Column(name = "principal_amount", scale = 6, precision = 19, nullable =
true)
+ @Column(name = "principal_amount", scale = 6, precision = 19)
private BigDecimal principal;
- @Column(name = "principal_completed_derived", scale = 6, precision = 19,
nullable = true)
+ @Column(name = "principal_completed_derived", scale = 6, precision = 19)
private BigDecimal principalCompleted;
- @Column(name = "principal_writtenoff_derived", scale = 6, precision = 19,
nullable = true)
+ @Column(name = "principal_writtenoff_derived", scale = 6, precision = 19)
private BigDecimal principalWrittenOff;
- @Column(name = "interest_amount", scale = 6, precision = 19, nullable =
true)
+ @Column(name = "interest_amount", scale = 6, precision = 19)
private BigDecimal interestCharged;
- @Column(name = "interest_completed_derived", scale = 6, precision = 19,
nullable = true)
+ @Column(name = "interest_completed_derived", scale = 6, precision = 19)
private BigDecimal interestPaid;
- @Column(name = "interest_waived_derived", scale = 6, precision = 19,
nullable = true)
+ @Column(name = "interest_waived_derived", scale = 6, precision = 19)
private BigDecimal interestWaived;
- @Column(name = "interest_writtenoff_derived", scale = 6, precision = 19,
nullable = true)
+ @Column(name = "interest_writtenoff_derived", scale = 6, precision = 19)
private BigDecimal interestWrittenOff;
- @Column(name = "accrual_interest_derived", scale = 6, precision = 19,
nullable = true)
+ @Setter
+ @Column(name = "accrual_interest_derived", scale = 6, precision = 19)
private BigDecimal interestAccrued;
- @Column(name = "reschedule_interest_portion", scale = 6, precision = 19,
nullable = true)
+ @Setter
+ @Column(name = "reschedule_interest_portion", scale = 6, precision = 19)
private BigDecimal rescheduleInterestPortion;
- @Column(name = "fee_charges_amount", scale = 6, precision = 19, nullable =
true)
+ @Column(name = "fee_charges_amount", scale = 6, precision = 19)
private BigDecimal feeChargesCharged;
- @Column(name = "fee_charges_completed_derived", scale = 6, precision = 19,
nullable = true)
+ @Column(name = "fee_charges_completed_derived", scale = 6, precision = 19)
private BigDecimal feeChargesPaid;
- @Column(name = "fee_charges_writtenoff_derived", scale = 6, precision =
19, nullable = true)
+ @Column(name = "fee_charges_writtenoff_derived", scale = 6, precision = 19)
private BigDecimal feeChargesWrittenOff;
- @Column(name = "fee_charges_waived_derived", scale = 6, precision = 19,
nullable = true)
+ @Setter
Review Comment:
Unnecessary @Setter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
