adamsaghy commented on code in PR #4506:
URL: https://github.com/apache/fineract/pull/4506#discussion_r2020634533
##########
fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/AccrualBasedAccountingProcessorForLoan.java:
##########
@@ -1300,14 +1296,24 @@ private void
createJournalEntriesForRefundForActiveLoan(LoanDTO loanDTO, LoanTra
if (principalAmount != null &&
principalAmount.compareTo(BigDecimal.ZERO) > 0) {
totalDebitAmount = totalDebitAmount.add(principalAmount);
- this.helper.createCreditJournalEntryOrReversalForLoan(office,
currencyCode, AccrualAccountsForLoan.LOAN_PORTFOLIO,
- loanProductId, paymentTypeId, loanId, transactionId,
transactionDate, principalAmount, !isReversal);
+ if (isReversal) {
Review Comment:
I wonder whether we can remove the "isReversal" flag from here as well and
handle same way the journal entry creation as for the other transaction type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
