adamsaghy commented on code in PR #4510:
URL: https://github.com/apache/fineract/pull/4510#discussion_r2030989930
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/serialization/LoanApplicationValidator.java:
##########
@@ -934,13 +926,6 @@ public void validateForModify(final JsonCommand command,
final Loan loan) {
.notExceedingLengthOf(100);
}
- if
(this.fromApiJsonHelper.parameterExists(LoanApiConstants.fundIdParameterName,
element)) {
Review Comment:
This is a conditional check, if fundId was provided, we need to validate
it's value. If it is not mandatory, then the value of this field can be empty,
hence not validation done.... I still dont see why to remove this **conditional
validation**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
