adamsaghy commented on code in PR #4544:
URL: https://github.com/apache/fineract/pull/4544#discussion_r2031378250


##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanTransaction.java:
##########
@@ -307,7 +307,8 @@ public static LoanTransaction 
copyTransactionProperties(final LoanTransaction lo
                 loanTransaction.feeChargesPortion, 
loanTransaction.penaltyChargesPortion, loanTransaction.overPaymentPortion,
                 loanTransaction.reversed, loanTransaction.paymentDetail, 
loanTransaction.externalId);
 
-        if 
(LoanTransactionType.CHARGE_PAYMENT.equals(loanTransaction.getTypeOf())) {
+        if 
(LoanTransactionType.CHARGE_PAYMENT.equals(loanTransaction.getTypeOf())
+                || 
LoanTransactionType.REPAYMENT_AT_DISBURSEMENT.equals(loanTransaction.getTypeOf()))
 {

Review Comment:
   We are not reverse-replay Repayment at disbursement transactions.. These 
never changes... 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to