galovics commented on code in PR #4566:
URL: https://github.com/apache/fineract/pull/4566#discussion_r2040594108
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientIdentifiersApiResource.java:
##########
@@ -87,16 +89,12 @@ public class ClientIdentifiersApiResource {
+
"clients/1/identifiers?fields=documentKey,documentType,description")
@ApiResponses({
@ApiResponse(responseCode = "200", description = "OK", content =
@Content(array = @ArraySchema(schema = @Schema(implementation =
ClientIdentifiersApiResourceSwagger.GetClientsClientIdIdentifiersResponse.class))))
})
- public String retrieveAllClientIdentifiers(@Context final UriInfo uriInfo,
+ public List<ClientIdentifierData> retrieveAllClientIdentifiers(
Review Comment:
Don't forget to remove the Swagger annotations from the method, otherwise
they'll be used to generate the client classes instead of using the actual
return type of the method here. (Same as for your other changes).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
