7ossam7atem1 commented on code in PR #4413:
URL: https://github.com/apache/fineract/pull/4413#discussion_r2041686571
##########
fineract-accounting/src/main/java/org/apache/fineract/accounting/provisioning/service/ProvisioningEntriesReadPlatformServiceImpl.java:
##########
@@ -43,6 +43,11 @@
@Slf4j
public class ProvisioningEntriesReadPlatformServiceImpl implements
ProvisioningEntriesReadPlatformService {
+ private static final String DUE_DATE_COLUMN = "sch.duedate";
+ private static final String CREATED_DATE_COLUMN = "created_date";
+ private static final String SELECT_KEYWORD = "select ";
+ private static final String AND_KEYWORD = " and ";
Review Comment:
> Honestly I'm not sure if this refactor improves code quality at all. You
just extracted standard SQL keywords into constants and in some places it makes
it even worse to read the code.
>
> What would really improve the quality here is if you start rewriting the
native SQL into QueryDSL/JPQL/Criteria API anything that's typed.
I was thinking about that at first but I saw that keeping the use of native
SQL queries is important bc they are complex and critical for performance also
they are already optimized so converting them to JPA would be a headache and
might impact performance , for that I thought that It's better to organize them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
