adamsaghy commented on code in PR #4571:
URL: https://github.com/apache/fineract/pull/4571#discussion_r2042261362
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/event/external/service/serialization/serializer/loan/LoanProductBusinessEventSerializer.java:
##########
@@ -18,24 +18,26 @@
*/
package
org.apache.fineract.infrastructure.event.external.service.serialization.serializer.loan;
+import java.util.List;
import lombok.RequiredArgsConstructor;
import org.apache.avro.generic.GenericContainer;
import org.apache.fineract.avro.generator.ByteBufferSerializable;
import org.apache.fineract.avro.loan.v1.LoanProductDataV1;
import org.apache.fineract.infrastructure.event.business.domain.BusinessEvent;
import
org.apache.fineract.infrastructure.event.business.domain.loan.product.LoanProductBusinessEvent;
import
org.apache.fineract.infrastructure.event.external.service.serialization.mapper.loan.LoanProductDataMapper;
-import
org.apache.fineract.infrastructure.event.external.service.serialization.serializer.BusinessEventSerializer;
+import
org.apache.fineract.infrastructure.event.external.service.serialization.serializer.ExternalEventCustomDataSerializer;
import org.apache.fineract.portfolio.loanproduct.data.LoanProductData;
import
org.apache.fineract.portfolio.loanproduct.service.LoanProductReadPlatformService;
import org.springframework.stereotype.Component;
@Component
@RequiredArgsConstructor
-public class LoanProductBusinessEventSerializer implements
BusinessEventSerializer {
+public class LoanProductBusinessEventSerializer extends
AbstractLoanBusinessEventSerializer<LoanProductBusinessEvent> {
Review Comment:
@alberto-art3ch Would you mind to rework the
`AbstractLoanBusinessEventSerializer`?
I believe this class can be renamed and reworked to focus on collecting and
adding value to custom data field, but not really loan specific... so we can
use it for loan, loan product, investor, etc. as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
