adamsaghy commented on code in PR #4577:
URL: https://github.com/apache/fineract/pull/4577#discussion_r2042393834
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/service/InterestScheduleModelRepositoryWrapperImpl.java:
##########
@@ -57,6 +64,39 @@ public String writeInterestScheduleModel(Loan loan,
ProgressiveLoanInterestSched
return jsonModel;
}
+ @Override
+ public Optional<ProgressiveLoanModel> findOneByLoanId(Long loanId) {
+ return loanModelRepository.findOneByLoanId(loanId);
+ }
+
+ @Override
+ public Optional<ProgressiveLoanInterestScheduleModel>
extractModel(Optional<ProgressiveLoanModel> progressiveLoanModel) {
+ return progressiveLoanModel.map(ProgressiveLoanModel::getJsonModel) //
+ .map(jsonModel ->
progressiveLoanInterestScheduleModelParserService.fromJson(jsonModel,
+
progressiveLoanModel.get().getLoan().getLoanProductRelatedDetail(),
MoneyHelper.getMathContext(),
+
progressiveLoanModel.get().getLoan().getLoanProduct().getInstallmentAmountInMultiplesOf()));
+ }
+
+ @Override
+ @Transactional
+ public Optional<ProgressiveLoanInterestScheduleModel>
getAndUpdateModel(Loan loan, LocalDate businessDate) {
+ Optional<ProgressiveLoanModel> progressiveLoanModel =
findOneByLoanId(loan.getId());
+ Optional<ProgressiveLoanInterestScheduleModel> savedModel;
+ if (progressiveLoanModel.isPresent() &&
!progressiveLoanModel.get().getBusinessDate().isAfter(businessDate)) {
Review Comment:
`!progressiveLoanModel.get().getBusinessDate().isAfter(businessDate)` should
be rather
`progressiveLoanModel.get().getBusinessDate().isBefore(businessDate)`, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
