vidakovic commented on PR #4281: URL: https://github.com/apache/fineract/pull/4281#issuecomment-2820686554
... good idea. Please note somewhere and let's add it in another PR. On Tue, Apr 22, 2025 at 9:21 AM Victor Pavlenko ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In > fineract-command/src/main/java/org/apache/fineract/command/persistence/converter/JsonAttributeConverter.java > <https://github.com/apache/fineract/pull/4281#discussion_r2053491312>: > > > +import lombok.SneakyThrows; > +import lombok.extern.slf4j.Slf4j; > + > ***@***.*** > ***@***.*** > ***@***.*** > +public class JsonAttributeConverter implements AttributeConverter<JsonNode, String> { > + // TODO: it would be nicer to use a native JSON type on the database side, but not every system supports this; > + // string/text are the lowest common denominator that should work on every database > + > + private final ObjectMapper mapper; > + > + @Override > + @SneakyThrows > + public String convertToDatabaseColumn(JsonNode source) { > + if (source != null) { > > What do you think about use Optional here and as return type Optional, to > avoid return null? > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/fineract/pull/4281#pullrequestreview-2783061978>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAC4ZLY2L3SZGQ2GZLPMVKL22XUW3AVCNFSM6AAAAABVW4PKFKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDOOBTGA3DCOJXHA> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
