marta-jankovics commented on code in PR #4542:
URL: https://github.com/apache/fineract/pull/4542#discussion_r2055174753
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/configuration/domain/ConfigurationDomainServiceJpa.java:
##########
@@ -60,6 +60,18 @@ public boolean isMakerCheckerEnabledForTask(final String
taskPermissionCode) {
return false;
}
+ @Override
+ public boolean isReplayable(final String taskPermissionCode) {
Review Comment:
As I suggested, yes. This information is useful. It is important to show the
reason why the checker step was not working. Better to fail already at the
maker step. Having the flag on the permission made it possible to avoid this
situation. But now, since maker-checker and sanitization still do not work
together, at least we should raise an error with user friendly message saying
that the invalid configuration should be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
