adamsaghy commented on code in PR #4625: URL: https://github.com/apache/fineract/pull/4625#discussion_r2086374718
########## fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanTransactionService.java: ########## @@ -0,0 +1,49 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.fineract.portfolio.loanaccount.service; + +import java.util.List; +import java.util.function.Predicate; +import java.util.stream.Collectors; +import org.apache.fineract.portfolio.loanaccount.domain.Loan; +import org.apache.fineract.portfolio.loanaccount.domain.LoanTransaction; +import org.apache.fineract.portfolio.loanaccount.domain.LoanTransactionComparator; +import org.springframework.stereotype.Service; + +@Service +public class LoanTransactionService { + + public List<LoanTransaction> retrieveListOfTransactionsForReprocessing(final Loan loan) { Review Comment: Lets fetch it from database based on the filters, so we dont need to filter through all existing transactions in Fineract (including reverted ones, accruals, other non-monetary, etc.). Ultimately we are trying to move away to use loan.getLoanTransactions() for anything as it fetches a huge chunk of details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
