adamsaghy commented on code in PR #4634:
URL: https://github.com/apache/fineract/pull/4634#discussion_r2087264129


##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanTransaction.java:
##########
@@ -456,6 +456,7 @@ public void resetDerivedComponents() {
         this.penaltyChargesPortion = null;
         this.overPaymentPortion = null;
         this.outstandingLoanBalance = null;
+        this.loanChargesPaid.clear();

Review Comment:
   I still not find this correct behaviour... I truly believe this breaks 
existing behaviour which relies on it is updating existing charges paid 
mappings... The situation you described is incorrect: We should either process 
latest or reprocess all transactions but not both!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to