mariiaKraievska commented on code in PR #4669:
URL: https://github.com/apache/fineract/pull/4669#discussion_r2095495450
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoansApiResource.java:
##########
@@ -1225,6 +1225,8 @@ private String stateTransitions(final Long loanId, final
String loanExternalIdSt
commandRequest = new
CommandWrapperBuilder().recoverFromGuarantor(resolvedLoanId).build();
} else if (CommandParameterUtil.is(commandParam, "assigndelinquency"))
{
commandRequest = builder.assignDelinquency(resolvedLoanId).build();
+ } else if (CommandParameterUtil.is(commandParam,
LoanApiConstants.CONTRACT_TERMINATION_COMMAND)) {
+ commandRequest = builder.applyContractTermination(loanId).build();
Review Comment:
Perhaps it is better to use resolvedLoanId instead of loanId here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
