adamsaghy commented on PR #4688: URL: https://github.com/apache/fineract/pull/4688#issuecomment-2906886645
> I mean I understand the intent here and it's good but this could have side-effects to the behavior of the business logic. > > The former approach (what you removed) is using Hibernate's 1st level cache to retrieve the loan transactions for a loan. That means whenever a loan is loaded with the corresponding transactions, it'll only see those transactions even if something during the time of execution changes in the database. > > Another thing with the change is the fact that now whenever we need the transaction list for a loan, it'll go to the database every time resulting in performance degradation. > > Thoughts @mariiaKraievska @adamsaghy ? > > UPDATE: probably the first issue doesn't exist currently in Fineract because I see the tests are green. we are talking about loan ids here. I see performance issue by the fact every transactions of the loan is always fertched and some other entities as well alongside with the transactions. these methods sole and only purpose was to support Fineract weird journal entry creation logic! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
