oleksii-novikov-onix commented on code in PR #4700:
URL: https://github.com/apache/fineract/pull/4700#discussion_r2111409539
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanChargePaidByRepository.java:
##########
@@ -18,14 +18,26 @@
*/
package org.apache.fineract.portfolio.loanaccount.domain;
+import java.util.List;
import org.springframework.data.jpa.repository.JpaRepository;
import org.springframework.data.jpa.repository.JpaSpecificationExecutor;
import org.springframework.data.jpa.repository.Query;
import org.springframework.data.repository.query.Param;
public interface LoanChargePaidByRepository extends
JpaRepository<LoanChargePaidBy, Long>, JpaSpecificationExecutor<LoanCharge> {
- @Query("select lp from LoanChargePaidBy lp where lp.loanCharge=:loanCharge
and lp.installmentNumber=:installmentNumber")
- LoanChargePaidBy getLoanChargePaidByLoanCharge(@Param("loanCharge")
LoanCharge loanCharge,
- @Param("installmentNumber") Integer installmentNo);
+ @Query("""
+ SELECT lcpb
+ FROM LoanChargePaidBy lcpb
+ JOIN lcpb.loanTransaction lt
+ JOIN lcpb.loanCharge lc
+ WHERE lt.loan = :loan
+ AND lt.reversed = false
+ AND (lt.typeOf =
org.apache.fineract.portfolio.loanaccount.domain.LoanTransactionType.ACCRUAL
+ OR lt.typeOf =
org.apache.fineract.portfolio.loanaccount.domain.LoanTransactionType.ACCRUAL_ADJUSTMENT)
+ AND (lt.feeChargesPortion > 0 OR lt.penaltyChargesPortion > 0)
+ AND lcpb.installmentNumber IS NULL
+ """)
+ List<LoanChargePaidBy>
findAccrualTransactionMappingsWithoutInstallmentNumber(@Param("loan") Loan
loan);
Review Comment:
Done
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanTransactionRepository.java:
##########
@@ -32,30 +36,9 @@
public interface LoanTransactionRepository extends
JpaRepository<LoanTransaction, Long>, JpaSpecificationExecutor<LoanTransaction>
{
- String FIND_ID_BY_EXTERNAL_ID = "SELECT lt.id FROM LoanTransaction lt
WHERE lt.externalId = :externalId";
- String FIND_LOAN_ID_BY_ID = "SELECT lt.loan.id FROM LoanTransaction lt
WHERE lt.id = :id";
-
Optional<LoanTransaction> findByIdAndLoanId(Long transactionId, Long
loanId);
- @Query("""
- SELECT lt FROM LoanTransaction lt
- WHERE lt.loan.id = :loanId
- AND lt.typeOf IN :transactionTypes
- AND lt.id NOT IN :existingTransactionIds
- AND lt.reversed = false
- """)
- List<LoanTransaction>
findNewTransactionsByLoanIdAndTypeAndNotInIds(@Param("loanId") Long loanId,
- @Param("transactionTypes") List<LoanTransactionType>
transactionTypes,
- @Param("existingTransactionIds") List<Long>
existingTransactionIds);
-
- @Query("""
- SELECT lt FROM LoanTransaction lt
- WHERE lt.loan.id = :loanId
- AND lt.typeOf IN :transactionTypes
- AND lt.reversed = false
- """)
- List<LoanTransaction> findNewTransactionsByLoanIdAndType(@Param("loanId")
Long loanId,
- @Param("transactionTypes") List<LoanTransactionType>
transactionTypes);
+ List<LoanTransaction> findByLoan(Loan loan);
Review Comment:
Removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
