Napho commented on code in PR #4710:
URL: https://github.com/apache/fineract/pull/4710#discussion_r2114029563
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java:
##########
@@ -578,11 +578,10 @@ private void disburseLoan(JsonCommand command, boolean
isPaymentTypeApplicableFo
final Money interestApplied = Money.of(loan.getCurrency(),
loan.getSummary().getTotalInterestCharged());
/*
- * Add an interest applied transaction of the interest is accrued
upfront (Up front accrual), no accounting or
- * cash based accounting is selected
+ * Add an interest applied transaction of the interest is accrued
upfront (Up front accrual)
*/
if (((loan.isMultiDisburmentLoan() &&
loan.getDisbursedLoanDisbursementDetails().size() == 1) ||
!loan.isMultiDisburmentLoan())
- &&
loan.isNoneOrCashOrUpfrontAccrualAccountingEnabledOnLoanProduct()) {
+ && loan.isUpfrontAccrualAccountingEnabledOnLoanProduct()) {
Review Comment:
Cash accounting is backed by journal entries but the records are added only
when value is actually delivered (interest in the case of this implementation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
