meonkeys opened a new pull request, #4760: URL: https://github.com/apache/fineract/pull/4760
* fix various typos, spacing, formatting issues * fix links to legacy docs in API docs * update keycloak oauth dev instructions * update default oauth URL for latest Keycloak * use consistent quoting in oauth docs (single quotes) * use asciidoc auto-enumerated lists whenever possible * migrate security topics from readme into asciidoc: oauth, 2FA, HTTPS * move :hardbreaks: setting to config file so all config settings are in one place. (I think it's fine that `license.adoc` will use hardbreaks -- that's how the plain text version is formatted so it should look more familiar) * add intro to security chapter * migrate in Securing Fineract wiki content from https://cwiki.apache.org/confluence/display/FINERACT/Securing+Fineract * just say "oauth" (not "oauth2") to conform terminology throughout docs -- OAuth 2.0 is just the latest version * cross-ref HTTPS section from Securing Fineract * reposition hardening options as tips * see also: https://lists.apache.org/thread/81qdxttffp6wn23c48zvk93hc13373qv ## Description Describe the changes made and why they were made. See also: https://issues.apache.org/jira/browse/FINERACT-2310 ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update unit or integration tests for verifying the changes made. - [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions. - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.) FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
