adamsaghy commented on code in PR #4783:
URL: https://github.com/apache/fineract/pull/4783#discussion_r2155221858
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformService.java:
##########
@@ -155,4 +150,17 @@ org.springframework.data.domain.Page<LoanTransactionData>
retrieveLoanTransactio
List<Long> retrieveLoanIdsByExternalIds(List<ExternalId> externalIds);
boolean existsByLoanId(Long loanId);
+
+ Collection<LoanTermVariationsData> retrieveLoanTermVariations(Long loanId,
Integer termType);
+
Review Comment:
Seems unrelated changes, please raise a separate PR!
Also drop `Collection` return `List` or `Set` based on whether you need
ordering or not!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
