adamsaghy commented on code in PR #4770:
URL: https://github.com/apache/fineract/pull/4770#discussion_r2157032949
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/AbstractLoanRepaymentScheduleTransactionProcessor.java:
##########
@@ -179,8 +179,8 @@ public ChangedTransactionDetail
reprocessLoanTransactions(final LocalDate disbur
}
if (loanTransaction.isRepaymentLikeType() ||
loanTransaction.isInterestWaiver() || loanTransaction.isRecoveryRepayment()) {
- // pass through for new transactions
- if (loanTransaction.getId() == null) {
+ // pass through for fresh transactions that haven't been
processed yet
+ if (!loanTransaction.hasDerivedComponentsCalculated()) {
Review Comment:
i dont think we can do this... some of the loan transactions are created by
initial portions and they just got recalculated anyway...
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/AbstractLoanRepaymentScheduleTransactionProcessor.java:
##########
@@ -519,10 +517,9 @@ protected boolean
isNotObligationsMet(LoanRepaymentScheduleInstallment loanRepay
}
private void recalculateCreditTransaction(ChangedTransactionDetail
changedTransactionDetail, LoanTransaction loanTransaction,
- MonetaryCurrency currency, List<LoanRepaymentScheduleInstallment>
installments, List<LoanTransaction> transactionsToBeProcessed,
- MoneyHolder overpaymentHolder) {
- // pass through for new transactions
- if (loanTransaction.getId() == null) {
+ MonetaryCurrency currency, List<LoanRepaymentScheduleInstallment>
installments, MoneyHolder overpaymentHolder) {
+ // pass through for fresh transactions that haven't been processed yet
+ if (!loanTransaction.hasDerivedComponentsCalculated()) {
Review Comment:
i dont think we can do this... some of the loan transactions are created by
initial portions and they just got recalculated anyway...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
