kapil-panchal opened a new pull request, #4796:
URL: https://github.com/apache/fineract/pull/4796

   ## Description
   
   Describe the changes made and why they were made.
   
   The requirement is for the user to be able to add custom currency. The 
existing implementation
   has a predefined set of currencies, which are hard coded in the sql and 
created when the
   app was first installed. The existing functionality does not allow users to 
create their own 
   curriences, which is a limitation.
   
   API added which can now take a response body with necessary currency. The 
GET and PUT
   API's subsequently are able to put and update the newly added currency. 
Refer to FINERACT 1272 Jira
   ticket for more details.
   
   Ignore if these details are present on the associated [Apache Fineract JIRA 
ticket](https://github.com/apache/fineract/pull/1272).
   
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request 
- thanks!
   
   - [X] Write the commit message as per 
https://github.com/apache/fineract/#pull-requests
   - [X] Acknowledge that we will not review PRs that are not passing the build 
_("green")_ - it is your responsibility to get a proposed PR to pass the build, 
not primarily the project's maintainers.
   - [X] Create/update unit or integration tests for verifying the changes made.
   - [X] Follow coding conventions at 
https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
   - [X] Add required Swagger annotation and update API documentation at 
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with 
details of any API changes
   - [X] Submission is not a "code dump".  (Large changes can be made "in 
repository" via a branch.  Ask on the developer mailing list for guidance, if 
required.)
   
   FYI our guidelines for code reviews are at 
https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to