adamsaghy commented on code in PR #4791:
URL: https://github.com/apache/fineract/pull/4791#discussion_r2174747130
##########
fineract-core/src/main/java/org/apache/fineract/commands/service/CommandSourceService.java:
##########
@@ -108,6 +104,16 @@ public ErrorInfo generateErrorInfo(Throwable t) {
return errorHandler.handle(ErrorHandler.getMappable(t));
}
+ @Transactional(propagation = Propagation.REQUIRES_NEW)
+ public void saveFailedCommandSourcesNewTransaction(final
List<CommandSource> commandSources, final String errorMessage) {
+ commandSources.forEach(commandSource -> {
+ commandSource.setStatus(CommandProcessingResultType.ROLLBACK);
+ commandSource.setResult(errorMessage);
Review Comment:
Please do not override the "result" and "resultStatusCode". We should
reflect the "rollback" only in the "status" field!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
