mariiaKraievska commented on code in PR #4800:
URL: https://github.com/apache/fineract/pull/4800#discussion_r2189148486
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##########
@@ -1587,16 +1587,9 @@ private int adjustNumberOfRepayments() {
return repaymetsForAdjust;
}
- public int fetchNumberOfInstallmensAfterExceptions() {
+ public int fetchNumberOfInstallmentsAfterExceptions() {
if (!this.repaymentScheduleInstallments.isEmpty()) {
- List<LoanRepaymentScheduleInstallment> installments =
getRepaymentScheduleInstallments();
Review Comment:
I have reverted this change, since we agreed to disallow installment fee
charges that are calculated as a percentage of principal or interest when
interest recalculation is enabled.
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/SingleLoanChargeRepaymentScheduleProcessingWrapper.java:
##########
@@ -60,25 +60,21 @@ public void reprocess(final MonetaryCurrency currency,
final LocalDate disbursem
if (installment.isDownPayment()) {
continue;
}
- boolean installmentChargeApplicable =
!installment.isRecalculatedInterestComponent();
Review Comment:
I have reverted this change, since we agreed to disallow installment fee
charges that are calculated as a percentage of principal or interest when
interest recalculation is enabled.
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/SingleLoanChargeRepaymentScheduleProcessingWrapper.java:
##########
@@ -104,15 +100,15 @@ public void reprocess(final MonetaryCurrency currency,
final LocalDate disbursem
@NotNull
private Money calcChargeDue(final LocalDate periodStart, final LocalDate
periodEnd, final LoanCharge loanCharge,
final MonetaryCurrency currency, LoanRepaymentScheduleInstallment
period, final Money totalPrincipal, final Money totalInterest,
- boolean isInstallmentChargeApplicable, boolean isFirstPeriod,
Predicate<LoanCharge> predicate) {
+ boolean isFirstPeriod, Predicate<LoanCharge> predicate) {
Money zero = Money.zero(currency);
if (!predicate.test(loanCharge)) {
return zero;
}
if (loanCharge.isFeeCharge() && loanCharge.isDueAtDisbursement()) {
return zero;
}
- if (loanCharge.isInstalmentFee() && isInstallmentChargeApplicable) {
Review Comment:
I have reverted this change, since we agreed to disallow installment fee
charges that are calculated as a percentage of principal or interest when
interest recalculation is enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
