adamsaghy commented on code in PR #4844:
URL: https://github.com/apache/fineract/pull/4844#discussion_r2191908107
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanTransactionRepository.java:
##########
@@ -361,16 +361,27 @@ SELECT COALESCE(SUM(CASE WHEN lt.typeOf =
org.apache.fineract.portfolio.loanacco
AND (lt.typeOf =
org.apache.fineract.portfolio.loanaccount.domain.LoanTransactionType.CAPITALIZED_INCOME_AMORTIZATION
OR lt.typeOf =
org.apache.fineract.portfolio.loanaccount.domain.LoanTransactionType.CAPITALIZED_INCOME_AMORTIZATION_ADJUSTMENT)
""")
- BigDecimal getAmortizedAmount(@Param("loan") Loan loan);
+ BigDecimal getAmortizedAmountCapitalizedIncome(@Param("loan") Loan loan);
+
+ @Query("""
+ SELECT COALESCE(SUM(CASE WHEN lt.typeOf =
org.apache.fineract.portfolio.loanaccount.domain.LoanTransactionType.BUY_DOWN_FEE_AMORTIZATION
THEN lt.amount
+ WHEN lt.typeOf =
org.apache.fineract.portfolio.loanaccount.domain.LoanTransactionType.BUY_DOWN_FEE_AMORTIZATION_ADJUSTMENT
THEN -lt.amount
+ ELSE 0 END), 0) FROM LoanTransaction lt
+ WHERE lt.loan = :loan
+ AND lt.reversed = false
+ AND (lt.typeOf =
org.apache.fineract.portfolio.loanaccount.domain.LoanTransactionType.BUY_DOWN_FEE_AMORTIZATION
+ OR lt.typeOf =
org.apache.fineract.portfolio.loanaccount.domain.LoanTransactionType.BUY_DOWN_FEE_AMORTIZATION_ADJUSTMENT)
+ """)
+ BigDecimal getAmortizedAmountBuyDownFee(@Param("loan") Loan loan);
@Query("""
SELECT lt FROM LoanTransaction lt, LoanTransactionRelation ltr
WHERE lt.reversed = false
AND lt = ltr.fromTransaction
- AND ltr.toTransaction = :capitalizedIncome
+ AND ltr.toTransaction = :originationFee
AND ltr.relationType =
org.apache.fineract.portfolio.loanaccount.domain.LoanTransactionRelationTypeEnum.ADJUSTMENT
""")
- List<LoanTransaction>
findAdjustmentsForCapitalizedIncome(@Param("capitalizedIncome") LoanTransaction
capitalizedIncome);
+ List<LoanTransaction>
findAdjustmentsForOriginationFee(@Param("originationFee") LoanTransaction
originationFee);
Review Comment:
Is there a reason to rename from capitalized income? (we dont wanna use
"origination fee" definition)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
