kapil-panchal opened a new pull request, #4858: URL: https://github.com/apache/fineract/pull/4858
## Description This Pull request is in a draft state and it is for review of the efforts alignment with the Jira Tickets [FINERACT-2169](https://issues.apache.org/jira/browse/FINERACT-2169), https://issues.apache.org/jira/browse/FINERACT-2242 etc. This code is extensively commented for the reviewer to get an idea of the efforts and also the below: GO: 1) Command 2) Command Handler NOGO: 1) Nested Additional Commands and command handlers which are not in the scope of this Jira Ticket. e.g. Refer to CollectionSheetWritePlatformServiceJpaRepositoryImpl.java, private Map<String, Object> updateBulkDisbursals(final JsonCommand command) 2) Effort needs to be concerted. On successful review, another PR will be created as a release candidate. Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/2290). ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update unit or integration tests for verifying the changes made. - [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions. - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.) FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
