adamsaghy commented on code in PR #4837: URL: https://github.com/apache/fineract/pull/4837#discussion_r2213139996
########## fineract-savings/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccount.java: ########## @@ -337,12 +338,16 @@ public class SavingsAccount extends AbstractAuditableWithUTCDateTimeCustom<Long> @JoinColumn(name = "tax_group_id") private TaxGroup taxGroup; + @Column(name = "accrued_till_date") + protected LocalDate accruedTillDate; + @Column(name = "total_savings_amount_on_hold", scale = 6, precision = 19, nullable = true) private BigDecimal savingsOnHoldAmount; @OneToMany(cascade = CascadeType.ALL, mappedBy = "account", orphanRemoval = true, fetch = FetchType.LAZY) protected List<InteropIdentifier> identifiers = new ArrayList<>(); public transient ConfigurationDomainService configurationDomainService; + public transient SavingsAccountTransaction newTransaction; Review Comment: Please dont! I dont wanna see transient fields! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@fineract.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org