adamsaghy commented on code in PR #4867:
URL: https://github.com/apache/fineract/pull/4867#discussion_r2219016716
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanAccountDomainServiceJpa.java:
##########
@@ -206,7 +206,16 @@ private LoanTransaction
createInterestRefundLoanTransaction(Loan loan, LoanTrans
final ExternalId txnExternalId = externalIdFactory.create();
businessEventNotifierService.notifyPreBusinessEvent(new
LoanTransactionInterestRefundPreBusinessEvent(loan));
return LoanTransaction.interestRefund(loan, interestRefundAmount,
refundTransaction.getDateOf(), txnExternalId);
+ }
+ @Override
+ public LoanTransaction createManualInterestRefundWithAmount(final Loan
loan, final LoanTransaction targetTransaction,
+ final BigDecimal interestRefundAmount, final PaymentDetail
paymentDetail, final ExternalId txnExternalId) {
+ if (MathUtil.isZero(interestRefundAmount)) {
Review Comment:
Cannot really happen, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
