adamsaghy commented on code in PR #4887:
URL: https://github.com/apache/fineract/pull/4887#discussion_r2242319482
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/service/BuyDownFeeWritePlatformServiceImpl.java:
##########
@@ -210,6 +213,40 @@ public CommandProcessingResult buyDownFeeAdjustment(final
Long loanId, final Lon
.withClientId(loan.getClientId()).withLoanId(loan.getId()).build();
}
+ @Override
+ @Transactional
+ public Optional<LoanTransaction> reverseBuyDownFee(LoanTransaction
buyDownFeeTransaction) {
+ LoanTransaction amortizationTransaction = null;
+ Loan loan = buyDownFeeTransaction.getLoan();
+ BigDecimal totalAmortizationAmount = BigDecimal.ZERO;
+
+ final List<LoanTransactionRelation> loanTransactionRelations =
loanTransactionRelationRepository
Review Comment:
We dont need to fetch all the relations and go through on loan transactions
(and effectively fetch them) to make this decision. Please write a simply query
which returns the required information:
- boolean
- related transaction id
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
