magyari-adam commented on code in PR #4893:
URL: https://github.com/apache/fineract/pull/4893#discussion_r2242398504
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/service/BuyDownFeeWritePlatformServiceImpl.java:
##########
@@ -122,7 +125,7 @@ public CommandProcessingResult makeLoanBuyDownFee(final
Long loanId, final JsonC
loanJournalEntryPoster.postJournalEntries(loan,
existingTransactionIds, existingReversedTransactionIds);
// Notify business events
- businessEventNotifierService.notifyPostBusinessEvent(new
LoanBuyDownFeeTransactionCreatedBusinessEvent(buyDownFeeTransaction));
+ businessEventNotifierService.notifyPostBusinessEvent(new
LoanBuyDownFeeTransactionBusinessEvent(buyDownFeeTransaction));
businessEventNotifierService.notifyPostBusinessEvent(new
LoanBalanceChangedBusinessEvent(loan));
Review Comment:
Should we fire a LoanBalanceChanged event here? Buy down fees should not
have any impact on the schedule.
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/service/BuyDownFeeWritePlatformServiceImpl.java:
##########
@@ -202,14 +205,48 @@ public CommandProcessingResult buyDownFeeAdjustment(final
Long loanId, final Lon
// Notify business events
businessEventNotifierService
- .notifyPostBusinessEvent(new
LoanBuyDownFeeAdjustmentTransactionCreatedBusinessEvent(savedBuyDownFeeAdjustment));
+ .notifyPostBusinessEvent(new
LoanBuyDownFeeAdjustmentTransactionBusinessEvent(savedBuyDownFeeAdjustment));
businessEventNotifierService.notifyPostBusinessEvent(new
LoanBalanceChangedBusinessEvent(loan));
Review Comment:
Should we fire a LoanBalanceChanged event here? Buy down fees should not
have any impact on the schedule.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
