adamsaghy commented on code in PR #4886:
URL: https://github.com/apache/fineract/pull/4886#discussion_r2246157406
##########
fineract-core/src/main/java/org/apache/fineract/portfolio/savings/data/SavingsAccountData.java:
##########
@@ -144,6 +144,15 @@ public final class SavingsAccountData implements
Serializable {
private transient Long glAccountIdForSavingsControl;
private transient Long glAccountIdForInterestOnSavings;
+ private transient Long
glAccountIdForSavingsControlAcountPositiveInterestNegative;
+ private transient Long
glAccountIdForInterestReceivablePositiveInterestNegative;
+
+ private transient Long glAccountIdForOverdraftPorfolioNegative;
+ private transient Long glAccountIdForInterestReceivableNegative;
Review Comment:
Does this need to be transient? Usually having transient field on a DTO is a
serious anti-pattern... I would rather avoid them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
