adamsaghy commented on code in PR #4885: URL: https://github.com/apache/fineract/pull/4885#discussion_r2259855040
########## integration-tests/src/test/java/org/apache/fineract/integrationtests/SavingsAccrualIntegrationTest.java: ########## @@ -0,0 +1,143 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.fineract.integrationtests; + +import io.restassured.builder.RequestSpecBuilder; +import io.restassured.builder.ResponseSpecBuilder; +import io.restassured.http.ContentType; +import io.restassured.specification.RequestSpecification; +import io.restassured.specification.ResponseSpecification; +import java.math.BigDecimal; +import java.math.RoundingMode; +import java.time.LocalDate; +import java.time.format.DateTimeFormatter; +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.Locale; +import java.util.Map; +import org.apache.fineract.integrationtests.common.ClientHelper; +import org.apache.fineract.integrationtests.common.CommonConstants; +import org.apache.fineract.integrationtests.common.SchedulerJobHelper; +import org.apache.fineract.integrationtests.common.Utils; +import org.apache.fineract.integrationtests.common.accounting.Account; +import org.apache.fineract.integrationtests.common.accounting.AccountHelper; +import org.apache.fineract.integrationtests.common.accounting.JournalEntryHelper; +import org.apache.fineract.integrationtests.common.savings.SavingsAccountHelper; +import org.apache.fineract.integrationtests.common.savings.SavingsStatusChecker; +import org.junit.jupiter.api.Assertions; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.ValueSource; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class SavingsAccrualIntegrationTest { + + private static final Logger LOG = LoggerFactory.getLogger(SavingsAccrualIntegrationTest.class); + private ResponseSpecification responseSpec; + private RequestSpecification requestSpec; + private SavingsAccountHelper savingsAccountHelper; + private SchedulerJobHelper schedulerJobHelper; + private JournalEntryHelper journalEntryHelper; + private AccountHelper accountHelper; + + @BeforeEach + public void setup() { + Utils.initializeRESTAssured(); + this.requestSpec = new RequestSpecBuilder().setContentType(ContentType.JSON).build(); + this.requestSpec.header("Authorization", "Basic " + Utils.loginIntoServerAndGetBase64EncodedAuthenticationKey()); + this.responseSpec = new ResponseSpecBuilder().expectStatusCode(200).build(); + this.savingsAccountHelper = new SavingsAccountHelper(this.requestSpec, this.responseSpec); + this.schedulerJobHelper = new SchedulerJobHelper(this.requestSpec); + this.journalEntryHelper = new JournalEntryHelper(this.requestSpec, this.responseSpec); + this.accountHelper = new AccountHelper(this.requestSpec, this.responseSpec); + } + + @ParameterizedTest + @ValueSource(ints = { 10, 30 }) + public void testAccrualsAreGeneratedForDifferentPeriods(int daysToSubtract) { + // --- ARRANGE --- + + final Account assetAccount = this.accountHelper.createAssetAccount(); + final Account liabilityAccount = this.accountHelper.createLiabilityAccount(); + final Account incomeAccount = this.accountHelper.createIncomeAccount(); + final Account expenseAccount = this.accountHelper.createExpenseAccount(); + + final String interestRate = "5.0"; + final Integer savingsProductId = this.savingsAccountHelper.createSavingsProductWithAccrualAccounting(assetAccount, liabilityAccount, + incomeAccount, expenseAccount, interestRate); + Assertions.assertNotNull(savingsProductId, "Error creating savings product."); + + final Integer clientId = ClientHelper.createClient(this.requestSpec, this.responseSpec, "01 January 2020"); + Assertions.assertNotNull(clientId, "Error creating client."); + + final LocalDate startDate = LocalDate.now(Utils.getZoneIdOfTenant()).minusDays(10); + final String startDateString = DateTimeFormatter.ofPattern("dd MMMM yyyy", Locale.US).format(startDate); + + final Integer savingsAccountId = this.savingsAccountHelper.applyForSavingsApplicationOnDate(clientId, savingsProductId, + SavingsAccountHelper.ACCOUNT_TYPE_INDIVIDUAL, startDateString); + Assertions.assertNotNull(savingsAccountId, "Error applying for savings account."); + + this.savingsAccountHelper.approveSavingsOnDate(savingsAccountId, startDateString); + this.savingsAccountHelper.activateSavings(savingsAccountId, startDateString); + + final HashMap<String, Object> savingsStatus = SavingsStatusChecker.getStatusOfSavings(this.requestSpec, this.responseSpec, + savingsAccountId); + SavingsStatusChecker.verifySavingsIsActive(savingsStatus); + + this.savingsAccountHelper.depositToSavingsAccount(savingsAccountId, "10000", startDateString, CommonConstants.RESPONSE_RESOURCE_ID); + + // --- ACT --- + schedulerJobHelper.executeAndAwaitJob("Add Accrual Transactions For Savings"); + + // --- ASSERT --- + List<HashMap> allTransactions = savingsAccountHelper.getSavingsTransactions(savingsAccountId); + List<HashMap> accrualTransactions = new ArrayList<>(); + for (HashMap transaction : allTransactions) { + Map<String, Object> type = (Map<String, Object>) transaction.get("transactionType"); + if (type != null && Boolean.TRUE.equals(type.get("accrual"))) { + accrualTransactions.add(transaction); + } + } + Assertions.assertFalse(accrualTransactions.isEmpty(), "No accrual transactions were found."); + + long daysBetween = java.time.temporal.ChronoUnit.DAYS.between(startDate, LocalDate.now(Utils.getZoneIdOfTenant())); + long actualNumberOfTransactions = accrualTransactions.size(); + + Assertions.assertTrue(actualNumberOfTransactions >= daysBetween && actualNumberOfTransactions <= daysBetween + 1, "For a period of " + + daysBetween + " days, a close number of transactions was expected, but found " + actualNumberOfTransactions); + + BigDecimal principal = new BigDecimal("10000"); + BigDecimal rate = new BigDecimal(interestRate).divide(new BigDecimal(100)); + BigDecimal daysInYear = new BigDecimal("365"); + + BigDecimal expectedTotalAccrual = principal.multiply(rate).divide(daysInYear, 8, RoundingMode.HALF_UP) Review Comment: Why the hardcoded rounding mode?? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@fineract.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
