adamsaghy commented on code in PR #4925:
URL: https://github.com/apache/fineract/pull/4925#discussion_r2260127293
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/LoanCapitalizedIncomeTest.java:
##########
@@ -89,12 +90,15 @@ public void testLoanCapitalizedIncomeAmortization() {
transaction(50.0, "Capitalized Income", "01 January
2024"), //
transaction(0.55, "Capitalized Income Amortization", "01
January 2024") //
);
- final LoanDeferredIncomeData loanDeferredIncomeData =
loanTransactionHelper.fetchDeferredIncomeDetails(loanId);
-
assertTrue(loanDeferredIncomeData.getCapitalizedIncomeData().size() > 0);
- final CapitalizedIncomeDetails capitalizedIncomeData =
loanDeferredIncomeData.getCapitalizedIncomeData().get(0);
+ final LoanCapitalizedIncomeData loanCapitalizedIncomeData =
loanTransactionHelper.fetchDeferredIncomeDetails(loanId);
+
assertTrue(loanCapitalizedIncomeData.getCapitalizedIncomeData().size() > 0);
+ final CapitalizedIncomeDetails capitalizedIncomeData =
loanCapitalizedIncomeData.getCapitalizedIncomeData().get(0);
assertNotNull(capitalizedIncomeData);
assertEquals(50.0,
Utils.getDoubleValue(capitalizedIncomeData.getAmount()));
assertEquals(0.55,
Utils.getDoubleValue(capitalizedIncomeData.getAmortizedAmount()));
+ final List<CapitalizedIncomeDetails> capitalizedIncomeDetails =
loanTransactionHelper.fetchCapitalizedIncomeDetails(loanId);
+ assertNotNull(capitalizedIncomeDetails);
Review Comment:
Please do proper validation of the fields of `capitalizedIncomeDetails`!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
