adamsaghy commented on code in PR #4904:
URL: https://github.com/apache/fineract/pull/4904#discussion_r2272809191


##########
fineract-savings/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccount.java:
##########
@@ -3847,4 +3849,22 @@ public 
List<SavingsAccountTransactionDetailsForPostingPeriod> toSavingsAccountTr
                 .map(transaction -> 
transaction.toSavingsAccountTransactionDetailsForPostingPeriod(this.currency, 
this.allowOverdraft))
                 .toList();
     }
+
+    public void accrualsForSavingsReverse(SavingsAccountTransactionDTO 
transactionDTO, final boolean backdatedTxnsAllowedTill) {
+        List<SavingsAccountTransaction> accountTransactionsSorted = null;
+
+        if (backdatedTxnsAllowedTill) {
+            accountTransactionsSorted = retrieveSortedTransactions();
+        } else {
+            accountTransactionsSorted = retrieveListOfTransactions();
+        }
+        for (final SavingsAccountTransaction transaction : 
accountTransactionsSorted) {

Review Comment:
   Also i am missing test cases to cover the functionality.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to