adamsaghy commented on code in PR #4916:
URL: https://github.com/apache/fineract/pull/4916#discussion_r2272931116


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java:
##########
@@ -1350,8 +1349,6 @@ public CommandProcessingResult 
chargebackLoanTransaction(final Long loanId, fina
 
         handleChargebackTransaction(loan, newTransaction);
 
-        newTransaction = 
this.loanTransactionRepository.saveAndFlush(newTransaction);

Review Comment:
   if new transaction is not saved and flushed, there will be no id in the 
`businessEventNotifierService.notifyPostBusinessEvent(new 
LoanChargebackTransactionBusinessEvent(newTransaction));`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@fineract.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to