adamsaghy commented on code in PR #4948:
URL: https://github.com/apache/fineract/pull/4948#discussion_r2273313114
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/DatatableReportingProcessService.java:
##########
@@ -59,7 +60,8 @@ public Response processRequest(String reportName,
MultivaluedMap<String, String>
final String parameterTypeValue =
ApiParameterHelper.parameterType(queryParams) ? "parameter" : "report";
final Map<String, String> reportParams = getReportParams(queryParams);
ResponseHolder response = findReportExportService(exportMode) //
- .orElseThrow(() -> new IllegalArgumentException("Unsupported
export target: " + exportMode)) //
+ .orElseThrow(() -> new
PlatformInternalServerException("error.msg.report.export.mode.unavailable",
Review Comment:
Please return with `GeneralPlatformDomainRuleException` instead and dont
forget to attach test cases which ensures, the correct behaviour.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
