adamsaghy commented on code in PR #4885:
URL: https://github.com/apache/fineract/pull/4885#discussion_r2278921986
##########
fineract-savings/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsAccountReadPlatformService.java:
##########
@@ -69,4 +71,6 @@ List<SavingsAccountData>
retrieveAllSavingsDataForInterestPosting(boolean backda
List<SavingsAccountTransactionData>
retrieveAllTransactionData(List<String> refNo);
Long retrieveAccountIdByExternalId(ExternalId externalId);
+
+ Collection<SavingsAccrualData> retrievePeriodicAccrualData(LocalDate
tillDate, SavingsAccount savings);
Review Comment:
Please either use `List` or `Set`... we dont want `Collection`... way too
generic...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
