adamsaghy commented on code in PR #4876:
URL: https://github.com/apache/fineract/pull/4876#discussion_r2284494863
##########
fineract-accounting/src/main/java/org/apache/fineract/accounting/producttoaccountmapping/service/ProductToGLAccountMappingHelper.java:
##########
@@ -118,6 +119,13 @@ public void mergeProductToAccountMappingChanges(final
JsonElement element, final
this.accountMappingRepository.saveAndFlush(accountMapping);
}
}
+ } else {
+ final ProductToGLAccountMapping accountMapping =
this.accountMappingRepository.findCoreProductToFinAccountMapping(productId,
+ portfolioProductType.getValue(), accountTypeId);
+ if (portfolioProductType.isSavingProduct()) {
Review Comment:
For backward compatibility, i dont think we should allow to delete any
mappings. There could be existing savings account which rely on these mappings.
We can update, but not delete...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@fineract.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
