sayhaed commented on code in PR #4904:
URL: https://github.com/apache/fineract/pull/4904#discussion_r2308038810


##########
fineract-savings/src/main/java/org/apache/fineract/portfolio/savings/domain/SavingsAccount.java:
##########
@@ -3847,4 +3849,22 @@ public 
List<SavingsAccountTransactionDetailsForPostingPeriod> toSavingsAccountTr
                 .map(transaction -> 
transaction.toSavingsAccountTransactionDetailsForPostingPeriod(this.currency, 
this.allowOverdraft))
                 .toList();
     }
+
+    public void accrualsForSavingsReverse(SavingsAccountTransactionDTO 
transactionDTO, final boolean backdatedTxnsAllowedTill) {

Review Comment:
   Hi @adamsaghy 
   The process is designed to handle that scenario correctly. The reversal 
logic will find and reverse all accrual transactions on or after the backdated 
transaction's date, regardless of their previous state (whether they were 
already reversed or not).
   
   This ensures we always start with a clean slate before the recalculation 
step runs, which prevents any duplicate, active accruals for a given date.
   
   Hope that clarifies it!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@fineract.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to