adamsaghy commented on code in PR #5041:
URL: https://github.com/apache/fineract/pull/5041#discussion_r2362792155
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanDownPaymentHandlerServiceImpl.java:
##########
@@ -140,7 +141,7 @@ public void
handleRepaymentOrRecoveryOrWaiverTransaction(final Loan loan, final
if (processLatest) {
loanTransactionProcessingService.processLatestTransaction(loan.getTransactionProcessingStrategyCode(),
loanTransaction,
new TransactionCtx(loan.getCurrency(),
loan.getRepaymentScheduleInstallments(), loan.getActiveCharges(),
Review Comment:
You might wanna rework the `TransactionCtx` a little bit and use Builder
instead of constructor calls. With Builder pattern we can avoid set values to
fields that are irrelevant to us: `null` and `Collections.emptyList`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
