JohnAlva opened a new pull request, #5059:
URL: https://github.com/apache/fineract/pull/5059
## Description
Integration test started to fail:
org.apache.fineract.integrationtests.SchedulerJobsTestResults#testInterestTransferForSavings
Test result
org.opentest4j.AssertionFailedError: Verifying opening Balance ==> Expected
:100000.0 Actual :99998.86 <Click to see difference> at
org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
at
org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197) at
org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182) at
org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1156) at
org.apache.fineract.integrationtests.SchedulerJobsTestResults.testInterestTransferForSavings(SchedulerJobsTestResults.java:1337)
at java.base/java.lang.reflect.Method.invoke(Method.java:580) at
java.base/java.util.ArrayList.forEach(ArrayList.java:1596) at
java.base/java.util.ArrayList.forEach(ArrayList.java:1596)
Once it's fixed, remove @Disabled annotation from:
org.apache.fineract.integrationtests.SchedulerJobsTestResults#testInterestTransferForSavings
Seems there is an another failing test:
org.apache.fineract.integrationtests.SavingsInterestPostingTest
Test
testOverdraftAndInterestPosting_WithOverdraftProduct_WhitBalanceGreaterZero()
PASSED (4.1s) Test testPostInterestWithOverdraftProduct() FAILED (4s)
org.opentest4j.AssertionFailedError: Expected exactly one INTEREST posting
on posting date ==> expected: <1> but was: <0> at
app//org.apache.fineract.integrationtests.SavingsInterestPostingTest.testPostInterestWithOverdraftProduct(SavingsInterestPostingTest.java:133)
I was able to reproduce if i run `AccountTransferTest` (whole test class)
and after i run
`SavingsInterestPostingTest`.
Backend console log
Caused by: java.sql.BatchUpdateException: Batch entry 869 INSERT INTO
acc_gl_journal_entry(account_id,office_id,reversal_id,currency_code,transaction_id,savings_transaction_id,client_transaction_id,reversed,ref_num,manual_entry,entry_date,type_enum,amount,description,entity_type_enum,entity_id,created_on_utc,last_modified_on_utc,is_running_balance_calculated,office_running_balance,organization_running_balance,payment_details_id,transaction_date,share_transaction_id,
created_by, last_modified_by, submitted_on_date) VALUES (('0'::int8),
('18'::int8), (NULL), ('USD'), ('S243757'), ('243757'::int8), (NULL),
('FALSE'::boolean), (NULL), ('FALSE'::boolean), ('2013-04-01'::date),
('2'::int8), ('255.8444'::numeric), (NULL), ('2'::int8), ('36'::int8),
('2025-09-22 15:39:29.534134+00'::timestamp with time zone), ('2025-09-22
15:39:29.534134+00'::timestamp with time zone), ('FALSE'::boolean),
('0'::numeric), ('0'::numeric), (NULL), ('2013-04-01'::date), (NULL),
('2'::int8), ('2'::int8), ('202
5-03-01'::date)) was aborted: ERROR: insert or update on table
"acc_gl_journal_entry" violates foreign key constraint
"FK_acc_gl_journal_entry_acc_gl_account" Detail: Key (account_id)=(0) is not
present in table "acc_gl_account". Call getNextException to see other errors in
the batch.
## Checklist
Please make sure these boxes are checked before submitting your pull request
- thanks!
- [ ] Write the commit message as per
https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build
_("green")_ - it is your responsibility to get a proposed PR to pass the build,
not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at
https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with
details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in
repository" via a branch. Ask on the developer mailing list for guidance, if
required.)
FYI our guidelines for code reviews are at
https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
