mariiaKraievska commented on code in PR #5053:
URL: https://github.com/apache/fineract/pull/5053#discussion_r2431999296
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java:
##########
@@ -3021,7 +3361,7 @@ private void
updateRepaymentPeriodsAfterAccelerateMaturityDate(final Progressive
final RepaymentPeriod lastPeriod =
periodsBeforeAccelerateMaturity.getLast();
- final List<RepaymentPeriod> periodsToRemove =
repaymentPeriods.stream().filter(rp ->
rp.getFromDate().isAfter(transactionDate))
+ final List<RepaymentPeriod> periodsToRemove =
repaymentPeriods.stream().filter(rp ->
!rp.getFromDate().isBefore(transactionDate))
Review Comment:
I noticed this problem when, for example, transactionDate of the charge-off
transaction is 1st of March, and with the old code we left repaymentPeriod with
fromDate "1 March" - dueDate "1 April", which is incorrect, I believe, it
should be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
