adamsaghy commented on code in PR #5002:
URL: https://github.com/apache/fineract/pull/5002#discussion_r2372507585
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/domain/DepositAccountDomainServiceJpa.java:
##########
@@ -433,11 +433,9 @@ private CalendarInstance getCalendarInstance(final
RecurringDepositAccount accou
}
private void autoGenerateAccountNumber(final SavingsAccount account) {
Review Comment:
Please make sure all 3 services which generated account number behaves the
same:
- check whether account number generation needed (if customer not provided
one)
- generate account number
Prerequirements:
- account number generation depends on the id of Savings account: entity
must be saved before "new" account number can be generated (awful logic, but
that's how it works )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
