budaidev commented on code in PR #5093:
URL: https://github.com/apache/fineract/pull/5093#discussion_r2418483764
##########
fineract-e2e-tests-core/src/test/java/org/apache/fineract/test/stepdef/loan/LoanStepDef.java:
##########
@@ -2919,9 +2925,7 @@ public void
checkLoanAccrualTransactionNotCreatedBusinessEvent(String date) thro
em -> FORMATTER.format(em.getBusinessDate()).equals(date));
}
- @Then("{string} transaction on {string} got reverse-replayed on {string}")
- public void checkLoanAdjustTransactionBusinessEvent(String
transactionType, String transactionDate, String submittedOnDate)
- throws IOException {
+ public GetLoansLoanIdTransactions getLoadTransactionIdByDate(String
transactionType, String transactionDate) throws IOException {
Review Comment:
Probably typo: getLoadTransaction -> getLoanTransaction
##########
fineract-e2e-tests-core/src/test/java/org/apache/fineract/test/stepdef/loan/LoanStepDef.java:
##########
@@ -2934,35 +2938,90 @@ public void
checkLoanAdjustTransactionBusinessEvent(String transactionType, Stri
.filter(t ->
transactionDate.equals(FORMATTER.format(t.getDate())) &&
transactionType.equals(t.getType().getValue()))
.findFirst().orElseThrow(
() -> new IllegalStateException(String.format("No %s
transaction found on %s", transactionType, transactionDate)));
+ return loadTransaction;
+ }
+
+ public GetLoansLoanIdTransactionsTransactionIdResponse
getLoadTransactionIdById(Long transactionId) throws IOException {
Review Comment:
Probably typo: getLoadTransaction -> getLoanTransaction
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
