oleksii-novikov-onix commented on code in PR #5115:
URL: https://github.com/apache/fineract/pull/5115#discussion_r2452251759
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/service/LoanScheduleAssembler.java:
##########
@@ -363,9 +363,11 @@ private LoanApplicationTerms
assembleLoanApplicationTermsFrom(final JsonElement
final Boolean isInterestChargedFromDateSameAsDisbursalDateEnabled =
this.configurationDomainService
.isInterestChargedFromDateSameAsDisbursementDate();
- final Integer graceOnArrearsAgeing = allowOverridingGraceOnArrearsAging
- ?
this.fromApiJsonHelper.extractIntegerWithLocaleNamed(LoanProductConstants.GRACE_ON_ARREARS_AGEING_PARAMETER_NAME,
element)
- :
loanProduct.getLoanProductRelatedDetail().getGraceOnArrearsAgeing();
+ Integer graceOnArrearsAgeing = this.fromApiJsonHelper
+
.extractIntegerWithLocaleNamed(LoanProductConstants.GRACE_ON_ARREARS_AGEING_PARAMETER_NAME,
element);
+ if (!allowOverridingGraceOnArrearsAging || graceOnArrearsAgeing ==
null) {
+ graceOnArrearsAgeing =
loanProduct.getLoanProductRelatedDetail().getGraceOnArrearsAgeing();
+ }
Review Comment:
Unfortunately, the rest of the fields have similar issues. Do we need to fix
all of them along with the related tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
