adamsaghy commented on code in PR #5063:
URL: https://github.com/apache/fineract/pull/5063#discussion_r2464998826


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoanTransactionsApiResource.java:
##########
@@ -775,4 +783,50 @@ private Long getResolvedLoanIdWithExistsCheck(final Long 
loanId, final ExternalI
             throw new IllegalArgumentException("loanId and loanExternalId 
cannot be both null");
         }
     }
+
+    @POST

Review Comment:
   I think `GET` would be better here. Lets provide the parameters as query 
params.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to