adamsaghy commented on code in PR #5078:
URL: https://github.com/apache/fineract/pull/5078#discussion_r2503594110
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanRepaymentScheduleInstallment.java:
##########
@@ -1216,8 +1216,7 @@ private BigDecimal setScaleAndDefaultToNullIfZero(final
BigDecimal value) {
return value.setScale(6, MoneyHelper.getRoundingMode());
}
- public boolean isFirstNormalInstallment() {
- return loan.getRepaymentScheduleInstallments().stream().filter(rp ->
!rp.isDownPayment()).findFirst().stream()
- .anyMatch(rp -> rp.equals(this));
+ public boolean
isFirstNormalInstallment(List<LoanRepaymentScheduleInstallment> installments) {
Review Comment:
I was talking about why to provide `installments` as argument? What was the
problem with the original?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
