budaidev commented on code in PR #5153:
URL: https://github.com/apache/fineract/pull/5153#discussion_r2517337507
##########
fineract-e2e-tests-runner/src/test/resources/features/LoanChargeOff.feature:
##########
@@ -9949,3 +9949,25 @@ Feature: Charge-off
Then Loan Repayment schedule has the following data in Total row:
| Principal due | Interest | Fees | Penalties | Due | Paid | In
advance | Late | Outstanding |
| 546.14 | 24.69 | 0.0 | 10.0 | 580.83 | 308.59 | 308.59
| 0.0 | 272.24 |
+
+ @temp3
Review Comment:
do we need this temp3 tag?
##########
fineract-e2e-tests-core/src/test/java/org/apache/fineract/test/stepdef/loan/LoanStepDef.java:
##########
@@ -6045,6 +6045,23 @@ public void checkLoanAmortizationAllocationMapping(final
String nthTransactionSt
checkLoanAmortizationAllocationMappingData(resourceId,
loanAmortizationAllocationResponse.body(), table);
}
+ @Then("Loan has {double} total unpaid payable not due interest")
+ public void loanTotalUnpaidPayableNotDueInterest(double
totalUnpaidPayableNotDueInterestExpected) throws IOException {
+ Response<PostLoansResponse> loanCreateResponse =
testContext().get(TestContextKey.LOAN_CREATE_RESPONSE);
+ long loanId = loanCreateResponse.body().getLoanId();
+
+ Response<GetLoansLoanIdResponse> loanDetailsResponse =
loansApi.retrieveLoan(loanId, false, "repaymentSchedule", "", "").execute();
+ ErrorHelper.checkSuccessfulApiCall(loanDetailsResponse);
+ testContext().set(TestContextKey.LOAN_RESPONSE, loanDetailsResponse);
+
+ Double totalUnpaidPayableNotDueInterestActual =
loanDetailsResponse.body().getSummary().getTotalUnpaidPayableNotDueInterest()
+ .doubleValue();
+ assertThat(totalUnpaidPayableNotDueInterestActual)
+
.as(ErrorMessageHelper.wrongAmountInTotalUnpaidPayableDueInterest(totalUnpaidPayableNotDueInterestActual,
Review Comment:
This logic is a little bit strange with the naming. So the method says
wrongAmountInTotalUnpaidPayable**DueInterest**, but we are checking
totalUnpaidPayable**NotDue**InterestActual and
totalUnpaidPayable**NotDue**InterestExpected. Which one are we actually
checking?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
