rhopman commented on PR #5151:
URL: https://github.com/apache/fineract/pull/5151#issuecomment-3521598596

   Thanks @Akshat-Soni02, looks good to me!
   
   One suggestion: add a `preCondition` to the `changeSet` to make it more 
robust. See 
[0194_fix_missing_permission.xml](https://github.com/apache/fineract/blob/develop/fineract-provider/src/main/resources/db/changelog/tenant/parts/0194_fix_missing_permission.xml)
 for an example.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to