mariiaKraievska commented on code in PR #5122:
URL: https://github.com/apache/fineract/pull/5122#discussion_r2534471381
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java:
##########
@@ -3237,17 +3301,16 @@ private void
handleReAgeWithInterestRecalculationEnabled(final LoanTransaction l
loan.getLoanProduct().getLoanProductRelatedDetail().isAllowPartialPeriodInterestCalculation())
.mc(mc).build();
- LocalDate reAgePeriodStartDate =
calculateFirstReAgedPeriodStartDate(loanTransaction);
- LocalDate reageFirstDueDate =
loanTransaction.getLoanReAgeParameter().getStartDate();
+ final LocalDate reAgePeriodStartDate =
calculateFirstReAgedPeriodStartDate(loanTransaction);
+ final LocalDate reAgeFirstDueDate =
loanTransaction.getLoanReAgeParameter().getStartDate();
// Update the existing model with re-aged periods
- emiCalculator.updateModelRepaymentPeriodsDuringReAge(ctx.getModel(),
reAgePeriodStartDate, reageFirstDueDate,
+ emiCalculator.updateModelRepaymentPeriodsDuringReAge(ctx.getModel(),
reAgePeriodStartDate, reAgeFirstDueDate,
loanTransaction.getTransactionDate(), loanApplicationTerms,
mc);
updateInstallmentsByModelForReAging(loanTransaction, ctx);
loanTransaction.updateComponentsAndTotal(totalOutstandingPrincipal,
interestFromZeroedInstallments, Money.zero(currency),
Money.zero(currency));
- reprocessInstallments(installments);
Review Comment:
I turned it back, but modified the sorting
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java:
##########
@@ -3237,17 +3301,16 @@ private void
handleReAgeWithInterestRecalculationEnabled(final LoanTransaction l
loan.getLoanProduct().getLoanProductRelatedDetail().isAllowPartialPeriodInterestCalculation())
.mc(mc).build();
- LocalDate reAgePeriodStartDate =
calculateFirstReAgedPeriodStartDate(loanTransaction);
- LocalDate reageFirstDueDate =
loanTransaction.getLoanReAgeParameter().getStartDate();
+ final LocalDate reAgePeriodStartDate =
calculateFirstReAgedPeriodStartDate(loanTransaction);
+ final LocalDate reAgeFirstDueDate =
loanTransaction.getLoanReAgeParameter().getStartDate();
// Update the existing model with re-aged periods
- emiCalculator.updateModelRepaymentPeriodsDuringReAge(ctx.getModel(),
reAgePeriodStartDate, reageFirstDueDate,
+ emiCalculator.updateModelRepaymentPeriodsDuringReAge(ctx.getModel(),
reAgePeriodStartDate, reAgeFirstDueDate,
loanTransaction.getTransactionDate(), loanApplicationTerms,
mc);
updateInstallmentsByModelForReAging(loanTransaction, ctx);
loanTransaction.updateComponentsAndTotal(totalOutstandingPrincipal,
interestFromZeroedInstallments, Money.zero(currency),
Money.zero(currency));
- reprocessInstallments(installments);
Review Comment:
I returned it back, but modified the sorting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
